Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
first-load-fix.patch3.54 KBvan.dordafog

Comments

van.dordafog created an issue. See original summary.

anybody’s picture

anybody’s picture

@van.dordafog I think #3568267: Scripts matching source + Opt-Out + Toggled by default (+required) should not get blocked server-side might be the better and cleaner approach and I think required is not enough?

mikell’s picture

This patch made the oidc mcpf work for me together with patch from issue https://www.drupal.org/project/klaro/issues/3531419

anybody’s picture

@mikell did you try #3568267: Scripts matching source + Opt-Out + Toggled by default (+required) should not get blocked server-side instead? It's RTBC'd already and I think should solve that even better.

mikell’s picture

@anybody yes I tried but the toolbar.js from oidc_mcpf is not loading on time. Maybe I'm still missing something.

My configuration:
I added the burgerprofile as functional service and enabled settings:
'Toggled by default', 'Required', 'Opt out'
With following sources:

https://tni.widgets.burgerprofiel.dev-vlaanderen.be/api/v1/
https://prod.widgets.burgerprofiel.vlaanderen.be/api/v1/

'Block unknown external resources' and 'Process final HTML' is enabled.
'.*vlaanderen\.be.*' is added on 'Disable Klaro! element and dont block attributed resources on following url patterns'

jan kellermann’s picture

OptOut is buggy in klaro_js. See this issue: https://www.drupal.org/project/klaro_js/issues/3508237
Testing this MR would be great to step forward to next version of klaro.

anybody’s picture

@mikell: Your configuration looks correct and I'd code-wise expect #3568267: Scripts matching source + Opt-Out + Toggled by default (+required) should not get blocked server-side to fix your issue. Maybe I'm missing something?

The MR also has tests, so I think this one should be closed as duplicate, but we need to find out if and why it doesn't work in your case. Maybe indeed a side-effect of #3508237: Bugfix for #536: Check for optOut state while contextual rendering in your case?

jan kellermann’s picture

Status: Active » Needs review

Please review 3.1.x

Can you please check Klaro 3.1.0-RC? We updated the Klaro JS and fixed the Bug for services with optout-Option.

anybody’s picture

@mikell @van.dordafog could you try that please?

mikell’s picture

I have tested this with 3.1.0-rc2 and can confirm that it works for me.

jan kellermann’s picture

Status: Needs review » Reviewed & tested by the community
jan kellermann’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in 3.1.0

Thank you all for your work!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

Thank YOU @jan kellermann! :)

anybody’s picture

Nice! Happy to try 3.1.0 with the many improvements! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.