Problem/Motivation

Just ran into the interesting case that 

$(document).trigger(
  isActive ? 'drupalTourStarted' : 'drupalTourStopped',
);

is being executed before
Drupal.tour.* functions are defined.

So if you're using that event, these functions are undefined.

We need to switch the order :)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork tour-3567257

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !133

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Needs review » Reviewed & tested by the community

Yes, it works well now!

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @smustgrave!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.