Problem/Motivation

In general this works, but despite the event used (I tried blur and keyup), the network tab shows that the requests are triggered, but the response if often
{"value":""}
even if the request contains the entered address as request parameter.

Still this works somehow and the empty value does not clear the field, but I don't understand why and how that happens... Should be investigated sooner or later

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork username_suggester-3567032

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil’s picture

grevil commented
Status: Active » Needs work

Yes indeed, "keyup" doesn't make much sense anymore, since we are always validating the mail adress in the Controller. So if it is an invalid Mail Adress, the Controller will return value => '': https://git.drupalcode.org/project/username_suggester/-/blob/1.x/src/Con...

We should add a setting for this.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Done.

anybody opened merge request !2

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

LGTM, please test finally then we can merge it. If risky, let's keep the service despite the setting.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Works like a charm.

  • grevil committed f27c1c8c on 1.x authored by anybody 
    feat: #3567032 Server often returns an empty value even if an email...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.