Problem/Motivation

https://git.drupalcode.org/issue/drupal-2921627/-/jobs/7892733#L471

Image (Drupal\Tests\ckeditor5\FunctionalJavascript\Image)
     ✔ Attribute retention during upcasting
     ✔ Image settings form
     ✔ Can upload svg
     ✔ Image arbitrary html
     ✘ Linkability
       ┐
       ├ Behat\Mink\Exception\ElementNotFoundException: Element matching css "a[href="http://www.drupal.org/association"] img[src*="image-test.png"]" not found.
       │
       │ /builds/issue/drupal-2921627/vendor/behat/mink/src/WebAssert.php:465
       │ /builds/issue/drupal-2921627/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestBaselineTrait.php:232
       ┴

Steps to reproduce

Baseline MR (with no real changes):
https://git.drupalcode.org/project/drupal/-/merge_requests/14329

Repeat Drupal\Tests\ckeditor5\FunctionalJavascript\ImageTest 100x:
https://git.drupalcode.org/issue/drupal-3566845/-/jobs/7981133 (failed 2x)

Proposed resolution

Use waitForElement() instead of directly calling elementExists() after pressButton().

https://git.drupalcode.org/project/drupal/-/merge_requests/14330

Repeat Drupal\Tests\ckeditor5\FunctionalJavascript\ImageTest 100x:
https://git.drupalcode.org/issue/drupal-3566845/-/jobs/7981305 (passed 100/100)

Remaining tasks

  1. Repeat test job for Drupal\Tests\ckeditor5\FunctionalJavascript\ImageTest on both MRs.
  2. Verify results.
  3. Reviews / refinements.
  4. RTBC.
  5. Commit / rejoice.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3566845

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

kentr’s picture

kentr commented
Parent issue: #3566844: [random test failure] MediaTest::testTranslationAlt » #2829040: [meta] Known intermittent, random, and environment-specific test failures

dww made their first commit to this issue’s fork.

dww opened merge request !14330

dww opened merge request !14329

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Issue summary: View changes
Status: Active » Needs work
Issue tags: +Bug Smash Initiative

Opened a pair of MRs for this.

Just waiting for the real MR's pipeline to get far enough that I can spawn the repeat test job, then I'll set this to NR.

dww’s picture

dww
we/he/they
commented
Assigned: dww » Unassigned
Issue summary: View changes
Status: Needs work » Needs review

https://git.drupalcode.org/issue/drupal-3566845/-/jobs/7981133 (for the baseline) failed 2 / 100.

https://git.drupalcode.org/issue/drupal-3566845/-/jobs/7981305 (for the fix) is now running 100x.

dww’s picture

dww
we/he/they
commented
Issue summary: View changes
dww’s picture

dww
we/he/they
commented

Hah! How extremely appropriate. The main FunctionalJavascript run on the baseline MR also failed on ImageTest 😂

https://git.drupalcode.org/issue/drupal-3566845/-/jobs/7981076

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Once again, you can't argue with results. The MR looks good to me and it's in line with the other recent random test failure fixes.

  • catch committed bec2d458 on 11.3.x 
    fix: #3566845 [random test failure] ImageTest::testLinkability

By:...

  • catch committed 240ac43e on 11.x 
    fix: #3566845 [random test failure] ImageTest::testLinkability

By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14330

dww closed merge request !14329

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.