Problem/Motivation

ResponsiveImageFieldUiTest::testResponsiveImageFormatterUi() contains a race condition and will randomly fail.

Steps to reproduce

https://git.drupalcode.org/issue/drupal-3565152/-/jobs/7809827
https://git.drupalcode.org/project/drupal/-/merge_requests/6111/pipeline... (mentioned at #2829040-208: [meta] Known intermittent, random, and environment-specific test failures)

Proposed resolution

Before

    $page->pressButton('Save');
    $assert_session->responseContains("Select a responsive image style.");

After

    $page->pressButton('Save');
    $this->assertTrue($assert_session->waitForText('Select a responsive image style.'));

MR with the fix

https://git.drupalcode.org/project/drupal/-/merge_requests/14198
Repeat ResponsiveImageFieldUiTest 400x:
- https://git.drupalcode.org/issue/drupal-3565218/-/jobs/7813235
- All passed

MR without the fix

https://git.drupalcode.org/project/drupal/-/merge_requests/14199
Repeat ResponsiveImageFieldUiTest 400x:
- https://git.drupalcode.org/issue/drupal-3565218/-/jobs/7813257
- Failed 1 / 400

Remaining tasks

  1. Review
  2. RTBC
  3. Commit
  4. Rejoice

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3565218

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dww created an issue. See original summary.

dww’s picture

Issue summary: View changes
Status: Active » Needs review
Issue tags: +Bug Smash Initiative
dww’s picture

Issue summary: View changes
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense and seems straight forward.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x and 10.6.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 1431f996 on 10.6.x
    fix: #3565218 [random test failure] ResponsiveImageFieldUiTest::...

  • catch committed 0b3f5b10 on 11.3.x
    fix: #3565218 [random test failure] ResponsiveImageFieldUiTest::...

  • catch committed f4830b50 on 11.x
    fix: #3565218 [random test failure] ResponsiveImageFieldUiTest::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.