Problem/Motivation
ResponsiveImageFieldUiTest::testResponsiveImageFormatterUi() contains a race condition and will randomly fail.
Steps to reproduce
https://git.drupalcode.org/issue/drupal-3565152/-/jobs/7809827
https://git.drupalcode.org/project/drupal/-/merge_requests/6111/pipeline... (mentioned at #2829040-208: [meta] Known intermittent, random, and environment-specific test failures)
Proposed resolution
Before
$page->pressButton('Save');
$assert_session->responseContains("Select a responsive image style.");
After
$page->pressButton('Save');
$this->assertTrue($assert_session->waitForText('Select a responsive image style.'));
MR with the fix
https://git.drupalcode.org/project/drupal/-/merge_requests/14198
Repeat ResponsiveImageFieldUiTest 400x:
- https://git.drupalcode.org/issue/drupal-3565218/-/jobs/7813235
- All passed
MR without the fix
https://git.drupalcode.org/project/drupal/-/merge_requests/14199
Repeat ResponsiveImageFieldUiTest 400x:
- https://git.drupalcode.org/issue/drupal-3565218/-/jobs/7813257
- Failed 1 / 400
Remaining tasks
- Review
- RTBC
- Commit
- Rejoice
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3565218
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
dwwComment #5
dwwComment #6
smustgrave commentedMakes sense and seems straight forward.
Comment #7
catchCommitted/pushed to 11.x and cherry-picked to 11.3.x and 10.6.x, thanks!