Problem/Motivation

When collecting actions for commit API requests, an additional variable is created from the tree for a path lookup, which inflates the memory usage more than necessary.
This is just a small change to reduce memory usage.

Issue fork config_patch_gitlab_api-3564478

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mhh created an issue. See original summary.

mhh opened merge request !12

mhh’s picture

mhh commented
Status: Active » Needs review
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Needs work
mhh’s picture

mhh commented
Assigned: mhh » Unassigned
Status: Needs work » Needs review
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Needs work

Thank you @mhh for explanations, I agree that indexed array would be easier to scan. I have one suggestion though, please check my comment. I hope it is an improvement. I you agree, please adjust the MR and I will merge it.

mhh’s picture

mhh commented
Status: Needs work » Needs review
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Fixed

Thank you, the change was merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.