Problem/Motivation

It would be useful to have the option to disable page_cache_query_ignore for redirect requests. Redirects may rely specifically on query string parameters in the source path, even if those are normally being ignored in regular requests yielding to 200 OK responses.

Steps to reproduce

n/a

Proposed resolution

Optionally fall back to the Drupal core page_cache logic if the response is a redirect.

Remaining tasks

  • Post a MR
  • Reviews

User interface changes

None

API changes

None

Data model changes

None

Issue fork page_cache_query_ignore-3563815

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alecsmrekar created an issue. See original summary.

alecsmrekar opened merge request !10

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good and works well, thanks!

  • 6ea74964 committed on 2.x 
    Issue #3563815 by alecsmrekar, plach: Add option to disable PCQI for...
validoll’s picture

validoll commented
Status: Reviewed & tested by the community » Fixed

Follow-up in a separate maintainer commit: replaced the unset($this->cid) with a NULL assignment to satisfy phpstan's hooked-property check on PHP 8.4 — no behaviour change.

Released in 2.5.0. Also fixes #3558520 and #3129330 for anyone who enables the new "Ignore redirects" option.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.