Problem/Motivation

Gitlab CI pipeline was added for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

Issue fork private_content-3563323

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

batigolix opened merge request !6

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Postponed

First the tests need to be merged before fixing code styling etc.

#2948622: Improve tests

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Priority: Normal » Major
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Postponed » Needs work
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs work » Needs review
arjenk’s picture

arjenk commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested MR !6 on Drupal 11.3. Locally phpcs goes to 0 errors, all 25 functional tests pass, and the pipeline is green.

The patch is large but mostly reformatting. Some deletion of dead code, and a move of define(). Only one phpstan deprecation ( variableGet(), in old D6 migration code) left, but the pipeline is green, so i would say RTBC.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.