Problem/Motivation

Once #3551360: Add third party settings and tree Node ID in field storage is merged in UI Patterns side, we need to rename _third_party_settings with third_party_settings to be able to use the feature (Style utilities in Entity View Override).

Because #3540614: Add third_party_settings to ui_patterns_slot_source schema (also on UI Patterns side) is not merged yet, we may have some config inspector warning the first days, but it worth it.

Proposed resolution

Rename.

Issue fork display_builder-3561975

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !181

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Active » Needs review

The pipeline was green. I manually run the "playwright (all)" job which was omitted and i have a warning. Not sure it is related to the current change because this job may not be run at every MR.

Once merged, we need to do some changes on display_builder_dev_tools too.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Replaced on dev_tools fixtures.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » mogtofu33
Status: Fixed » Needs work

Rebase fix.

  • mogtofu33 committed 95e0dfab on 1.0.x authored by pdureau 
    chore: #3561975 Rename _third_party_settings with third_party_settings...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.