Problem/Motivation

GenerateThemeTest explicitly tests to see if the .theme file exists and that src does not.

Once we convert Starterkit theme neither of those assertions are true.

Steps to reproduce

Convert starterkit
Run GenerateThemeTest

Proposed resolution

Convert starterkit theme
Check manually that theme generates
Update test to reflect new theme generation output

Remaining tasks

Review

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3560844

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Crediting @cmlara for helping me get the GenerateThemeTest working locally.

It turns out I had the wrong sqlite version, updating ddev and updating the project type to drupal11 fixed it for me.

nicxvan’s picture

Version: 11.x-dev » main
Status: Active » Needs review

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Rebased this one and did a search for hooks and believe they've all been captured/replaced.

alexpott’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 23ddf6a9243 to main and 272495e8343 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 272495e8 on 11.x
    task: #3560844 Update starterkit and GenerateThemeTests to handle OOP...

  • alexpott committed 23ddf6a9 on main
    task: #3560844 Update starterkit and GenerateThemeTests to handle OOP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.