Problem/Motivation

Having .ddev/xhprof/xhprof_prepend.php committed to the repository breaks Gitlab CI's phpcs automated code quality tests.

$ $COMPOSER_BIN_DIR/phpcs $DRUPAL_PROJECT_FOLDER -s --report-junit=junit.xml --report-full --report-summary --report-source --basepath=$DRUPAL_PROJECT_FOLDER $_PHPCS_EXTRA || EXIT_CODE=$?
FILE: .ddev/xhprof/xhprof_prepend.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
 22 | WARNING | Line exceeds 80 characters; contains 85 characters (Drupal.Files.LineLength.TooLong)
 41 | WARNING | Line exceeds 80 characters; contains 92 characters (Drupal.Files.LineLength.TooLong)
 48 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
    |         | (Drupal.Commenting.DocComment.ShortSingleLine)
------------------------------------------------------------------------------------------------------------------------
Time: 321ms; Memory: 10MB
PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
.ddev/xhprof/xhprof_prepend.php                       1       2
----------------------------------------------------------------------
A TOTAL OF 1 ERROR AND 2 WARNINGS WERE FOUND IN 35 FILES
----------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
SOURCE                                                           COUNT
----------------------------------------------------------------------
Drupal.Files.LineLength.TooLong                                  2
Drupal.Commenting.DocComment.ShortSingleLine                     1
----------------------------------------------------------------------
A TOTAL OF 3 SNIFF VIOLATIONS WERE FOUND IN 2 SOURCES
----------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Add .ddev/xhprof/xhprof_prepend.php to .gitignore

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork svg_image_field-3560656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jwilson3 created an issue. See original summary.

jwilson3 opened merge request !47

  • jwilson3 committed 7209aaf4 on 2.3.x 
    Issue #3560656 by jwilson3: Ignore .ddev/xhprof/xhprof_prepend.php
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

This fix has been released in 2.3.6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.