Problem/Motivation

JSON:API tests are hard to debug because xdebug does not work.

Steps to reproduce

Try debugging a JSON:API test

Proposed resolution

Use JsonApiRequestTestTrait; not its own method.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557576

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13823

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Needs work

Think we should move away from core/modules/jsonapi/tests/src/Functional/JsonApiRequestTestTrait.php here as well then. Unforunately that means a deprecation i think.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Title: JsonApiFunctionalTestBase should use ApiRequestTrait » JsonApiFunctionalTestBase should use JsonApiRequestTestTrait
Issue summary: View changes

Updating issue summary based on #4.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review

Addressed the feedback in the merge request, rebased the branch, and confirmed that the pipeline has completed successfully.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Needs work
Issue tags: +Needs followup

I don't mind doing this in 2 steps, first this change, and then a child issue/follow up to remove `JsonApiRequestTestTrait` as a whole since it is such a weird little trait.

The test failure is unrelated.

Setting needs work for the follow up, will RTBC when that is up.