Problem/Motivation

Drupal\Core\FileTransfer\Form\FileTransferAuthorizeForm->setConnectionSettingsDefaults()() (Line: 312) triggers a deprecation in PHP 8.5

Steps to reproduce

Run \Drupal\Tests\system\Functional\System\SystemAuthorizeTest::testFileTransferHooks

Proposed resolution

Don't

Remaining tasks

User interface changes

Nonr

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557557

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +PHP 8.5
Parent issue: » #3546535: [meta] Deal with NULL as array key/offset
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13821

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

That same random javascript error, re-running is green

Exception: Deprecated function: Using null as an array offset is deprecated, use an empty string instead
Drupal\Core\FileTransfer\Form\FileTransferAuthorizeForm->setConnectionSettingsDefaults()() (Line: 312)

All green.

Also this file is marked deprecated to be removed in 12 so this fix doesn't break anything and isn't long for this world. LGTM

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13821

  • catch committed d130c43b on 11.3.x 
    fix: #3557557 Drupal\Core\FileTransfer\Form\FileTransferAuthorizeForm->...

  • catch committed 751b48f9 on 11.x 
    fix: #3557557 Drupal\Core\FileTransfer\Form\FileTransferAuthorizeForm->...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.