Overview

Ever since #3552069: Don't require SDC components to have a schema we seem to have very frequent CI failures (see the ocean of ❌ at https://git.drupalcode.org/project/canvas/-/commits/1.x?ref_type=HEADS) in SingleDirectoryComponentTest::testDiscovery():

1) Drupal\Tests\canvas\Kernel\Plugin\Canvas\ComponentSource\SingleDirectoryComponentTest::testDiscovery
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     32 => 'sdc.canvas_test_sdc.two_column',
     33 => 'sdc.canvas_test_sdc.video',
     34 => 'sdc.sdc_theme_test.bar',
-    35 => 'sdc.sdc_theme_test_base.my-card-no-schema',
-    36 => 'sdc.sdc_theme_test.lib-overrides',
-    37 => 'sdc.sdc_theme_test.my-card',
+    35 => 'sdc.sdc_theme_test.lib-overrides',
+    36 => 'sdc.sdc_theme_test.my-card',
+    37 => 'sdc.sdc_theme_test_base.my-card-no-schema',
 ]

/builds/project/canvas/tests/src/Kernel/Plugin/Canvas/ComponentSource/SingleDirectoryComponentTest.php:206

Proposed resolution

User interface changes

Issue fork canvas-3557410

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

wim leers created an issue. See original summary.

wim leers’s picture

Assigned: wim leers » Unassigned
Issue summary: View changes
Status: Active » Needs review
wim leers’s picture

Issue summary: View changes
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

One-character change to get to green CI: no need to wait for explicit approval! 🐌

  • wim leers committed d0cf2e0d on 1.x
    chore: #3557410 CI: regression since #3552069: frequent PHPUnit...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

penyaskito’s picture

Great catch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.