Problem/Motivation

Drupal\Core\Render\Element\RenderElementBase::preRenderAjaxForm() triggers deprecations when $settings['url'] is NULL because it uses it as an array key. It doesn't need to do this.

Steps to reproduce

Run \Drupal\Tests\image\Functional\ImageFieldDisplayTest::testImageFieldSettings on PHP 8.5

Proposed resolution

Don't

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13787

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Parent issue: » #3546535: [meta] Deal with NULL as array key/offset
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +PHP 8.5
ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Safety check looks good to me, hence moving into RTBC

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

One question on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13787

  • catch committed 14b2411c on 11.3.x 
    fix: #3557362 Drupal\Core\Render\Element\RenderElementBase::...

  • catch committed f09ec101 on 11.x 
    fix: #3557362 Drupal\Core\Render\Element\RenderElementBase::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.