Problem/Motivation

\Drupal\Tests\node\Unit\NodeOperationAccessTest::testRevisionOperations() doesn't mock account->id() correctly.

Steps to reproduce

Run \Drupal\Tests\node\Unit\NodeOperationAccessTest::testRevisionOperations() on PHP 8.5

Proposed resolution

Mock the method

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3555880

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13658

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

This is failing for the exact same reason as #3555522: Fix account mock in \Drupal\Tests\menu_link_content\Unit\MenuLinkContentEntityAccessTest::testUnrecognizedOperation for php 8.5, which got fixed and committed today. I reviewed that issue too. The fix for this issue is the same as the one that went in the other. It still looks good to me.

catch closed merge request !13658

  • catch committed 2953f891 on 11.3.x 
    Issue #3555880 by alexpott: \Drupal\Tests\node\Unit\...

  • catch committed e31827ba on 11.x 
    Issue #3555880 by alexpott: \Drupal\Tests\node\Unit\...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.