Hi everyone,

Thanks for the module, it’s been working great on our site.

We did ran into an issue on our CI build where the “key” config might not be imported yet when the module is installed.

This causes the install process to fail because the "__construct" method in "FlickrIntegrationSuiteApiProvider.php" attempts to load the API key from the "keyRepository" service, which returns null at that point.

See the error below

[error]  Error: Call to a member function getKeyValue() on null in Drupal\flickr_integration_suite\FlickrIntegrationSuiteApiProvider->__construct() (line 100 of /home/travis/build/nyunursing/meyers/docroot/modules/contrib/flickr_integration_suite/src/FlickrIntegrationSuiteApiProvider.php) #0 [internal function]: Drupal\flickr_integration_suite\FlickrIntegrationSuiteApiProvider->__construct(Object(Drupal\Core\Config\ConfigFactory), Object(Drupal\key\KeyRepository), Object(Drupal\Core\Http\ClientFactory), Object(Drupal\Core\Messenger\Messenger), Object(Drupal\Core\Cache\MemoryBackend))

Here's a patch that checks whether the key config exists before calling the "getKey" method:

Comments

sker101 created an issue. See original summary.

  • vishal.kadam committed be942851 on 1.0.x
    [#3554588] fix: PHP error during site install due to key not existing
    
vishal.kadam’s picture

Assigned: Unassigned » vishal.kadam
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.