Problem/Motivation

Drupal supports autowire for services, see change record: https://www.drupal.org/node/3218156

Proposed resolution

Autowire services

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork domain-3554240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !259

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request implements autowiring for services

mably made their first commit to this issue’s fork.

mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mably’s picture

mably commented

@idebr it looks like autowiring might have introduced some circular dependency bugs.

Getting this:

Symfony\\Component\\DependencyInjection\\Exception\\ServiceCircularReferenceException: Circular reference detected for service "domain_config_ui.factory", path: "options_request_listener -> router.route_provider -> path_processor_manager -> path_processor_language -> domain_config_ui.factory -> domain.config_factory_override -> exception.fast_404_html". in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 147

Investigating but still stuck for now on my dev instance...

Any help welcome :)

EDIT: Might not be related, I reverted the autowiring commit and I still get the WSOD :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.