Problem/Motivation

11 years ago in #2322809: Do not depend on event subscribers for security: Tighten routing security by access checking in matchRequest we removed the use of $this->router and $this->pathProcessor from \Drupal\config_translation\Controller\ConfigTranslationController, but never deprecated or removed these properties.

Steps to reproduce

Proposed resolution

  • Remove the properties
  • Use \Drupal\Core\DependencyInjection\DeprecatedServicePropertyTrait to deprecate them
  • Remove these params from the constructor and update the create method
  • Handle the deprecation in the constructor

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3551748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented

Working on it.

ritarshi_chakraborty opened merge request !13961

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented
Status: Active » Needs review

Can anyone please confirm if the test failures are due to the changes that I have made?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Not following why deprecated in 11.1.9? It would have to be deprecated in 11.4 at this point.

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

MR has conflicts

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.