Problem/Motivation

https://git.drupalcode.org/issue/drupal-3093378/-/jobs/6778778#L510

CKEditor5 (Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5)
     ✔ Existing content
     ✔ Headings plugin
     ✘ Language of parts plugin
       ┐
       ├ Behat\Mink\Exception\ExpectationException: The string "Added text format ckeditor5." was not found anywhere in the HTML response of the current page.
       │
       │ /builds/issue/drupal-3093378/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/issue/drupal-3093378/vendor/behat/mink/src/WebAssert.php:363
       │ /builds/issue/drupal-3093378/core/tests/Drupal/Tests/WebAssert.php:559
       │ /builds/issue/drupal-3093378/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php:216
       │ /builds/issue/drupal-3093378/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php:154
       ┴
     ✔ Active tabs maintained
     ✔ Editor file reference integration
     ✔ Emphasis
     ✔ List plugin
     ✔ Save

Steps to reproduce

Baseline MR: https://git.drupalcode.org/project/drupal/-/merge_requests/14334
Repeat 250x: https://git.drupalcode.org/issue/drupal-3550787/-/jobs/7986131 (failed 6 / 250)

Proposed resolution

Fix MR: https://git.drupalcode.org/project/drupal/-/merge_requests/14335
Repeat 250x: https://git.drupalcode.org/issue/drupal-3550787/-/jobs/7986201 (pass 250 / 250)

Remaining tasks

  1. Verify test results on both MRs
  2. Reviews / refinements
  3. RTBC
  4. Commit / rejoince

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3550787

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

kentr’s picture

kentr commented

I believe random test failures are supposed to be critical.

kentr’s picture

kentr commented
Priority: Normal » Critical

Heh. Didn't actually change it.

dww made their first commit to this issue’s fork.

dww opened merge request !14334

dww opened merge request !14335

dww’s picture

dww
we/he/they
commented
Issue summary: View changes
Status: Active » Needs work
Issue tags: +Bug Smash Initiative
dww’s picture

dww
we/he/they
commented
Issue summary: View changes
Status: Needs work » Needs review

Ready for review:

  • Baseline MR failed 6 / 250
  • Fix MR passed 250 / 250
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Well that's great stat! Can't argue with the results.

acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Needs review

Same comment as #3520036: [random test failure] CKEditor5MarkupTest here - we should be using submitForm instead of pressing buttons. In my experience that removes the need for a wait.

acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

Discussed in slack, there shouldn't be any difference between submitForm or press (since submitForm does a press anyway).

catch closed merge request !14335

  • catch committed bb2acb40 on 11.3.x 
    fix: #3550787 [random test failure] CKEditor5Test::...

  • catch committed 540a232d on 11.x 
    fix: #3550787 [random test failure] CKEditor5Test::...

  • catch committed fd1ecc05 on main 
    fix: #3550787 [random test failure] CKEditor5Test::...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, 11.x, and 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed d2c033e5 on 10.6.x authored by catch 
    fix: #3550787 [random test failure] CKEditor5Test::...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also backported to 10.6.x, it applies cleanly so why not.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.