Problem/Motivation

 ------ -------------------------------------------------------------------------------------------- 
  Line   src/Service/EmailHandler.php                                                                
 ------ -------------------------------------------------------------------------------------------- 
  513    Call to deprecated method renderPlain() of interface Drupal\Core\Render\RendererInterface:  
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use                                     
           \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.                       
         🪪  method.deprecated                                                                       
 ------ -------------------------------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------- 
  Line   src/Controller/EasyEmailController.php                                         
 ------ ------------------------------------------------------------------------------- 
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use                        
           \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.          
         🪪  method.deprecated                                                                            
 ------ -------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Handle 10.3.0+ and less than 10.3.0

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork easy_email-3549842

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !52

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review
bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes

zengenuity made their first commit to this issue’s fork.

zengenuity’s picture

zengenuity commented

The renderInNewContext() method is left over from an earlier implementation, and I don't think it's in use any longer. I've removed it from the module instead of upgrading it to use renderInIsolation().

I also switched to using DeprecationHelper in EmailController

It would be great to have someone test with my changes, and then mark as RTBC.

bluegeek9’s picture

bluegeek9 commented

I avoid DeprecationHelper because it requires 10.3, and the minimum is 10.1 for Easy Email

DeprecationHelper helps modules support multiple versions of core

zengenuity’s picture

zengenuity commented

Okay, I think we should change the module requirements to ^10.3.

zengenuity’s picture

zengenuity commented

Added requirement for Drupal core ^10.3.

zengenuity’s picture

zengenuity commented
Status: Needs review » Fixed

Merged and released in 3.0.7.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.