Problem/Motivation

Block content are displayed within block and so have some special structure.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

grimreaper created an issue. See original summary.

grimreaper’s picture

Status: Active » Needs work

Need to discuss proposed solution because now block have no more title while in some places it is requested.

grimreaper’s picture

Default block has a lot of preprocesses, need to inspect that.

grimreaper’s picture

grimreaper’s picture

grimreaper’s picture

Assigned: grimreaper » Unassigned

The MR fixes the following cases:
- block content (using DB in its view display) displayed in Block Layout
- block content (using DB in its view display) displayed in Layout Builder

Case still missing: block content (using DB in its view display) displayed in Display Builder. At least Display Builder Page Layout for now, not tested with others.

Discussed with @pdureau, to fix with #3501797: Add a ContentEntity source for slots with a Content entity context as it will allow to call the rendering of the block content entity directly without trying to render it as a block.

grimreaper’s picture

StatusFileSize
new3.42 KB
grimreaper’s picture

Also block content (using DB in its view display) no more render the block title (at least in LB, not tested with Block Layout).

pdureau’s picture

Assigned: Unassigned » pdureau

To fix with #3501797: Add a ContentEntity source for slots with a Content entity context as it will allow to call the rendering of the block content entity directly without trying to render it as a block.

Indeed, so we will do the "final" fix during beta phase, once UI Patterns is ready.

For this beta1 MR, we need to do one those strategies:

  • ignore block content, with or without a placeholder, with or without a warning..
  • import them in a temporary way, which is storage stability future-proof: imported data must not break when the final fix will land, and no data migration is expected
grimreaper’s picture

Assigned: pdureau » Unassigned
Status: Needs work » Postponed
Issue tags: -display_builder-1.0.0-beta1 +display_builder-1.0.0-beta

Discussed with @pdureau.

grimreaper’s picture

Version: 1.0.x-dev » 1.0.0-beta2
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper’s picture

Version: 1.0.0-beta2 » 1.0.x-dev
Assigned: grimreaper » Unassigned

After a call with @g4mbini, confirming that the 2 issues were duplicated.

The problem is that with the proposed MR, there is no more contextual links to administer blocks in LB (or anywhere), so not usable in this state.

The solution needs to be discussed.

pdureau’s picture

Case still missing: block content (using DB in its view display) displayed in Display Builder. At least Display Builder Page Layout for now, not tested with others.

It may be the same issue as #3542276: Embedding a display in an other with a formatter (an other case of a display managed by Dsplay Builder nested in a display managed by Dsplay Builder)

grimreaper’s picture

Assigned: Unassigned » grimreaper
g4mbini’s picture

OK on my side. Tested it, I don't have any duplicate information displaying anymore.

grimreaper’s picture

Thanks, I will do a last check with Pierre, because of a case I had maybe because switching branch to test other MRs.

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Postponed » Needs review
g4mbini’s picture

Tested again, OK on my side again.

pdureau’s picture

Assigned: Unassigned » mogtofu33
Status: Needs review » Reviewed & tested by the community

that's great!

mogtofu33 made their first commit to this issue’s fork.

mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.