Problem/Motivation

Currently the starterkits don't ship with a package.json file but does ship with scss files but no way to compile them.

So if I'm a user who's looking to get up and running quickly for a small, non complex site, not having a complete starterkit hinders me.

Steps to reproduce

Proposed resolution

Ship with a basic package.json file that minimum has a build script to compile the scss into css so they can be used

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ui_suite_bootstrap-3548456

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Please ship with a package.json file in starterkits » Add a package.json file in starterkits

grimreaper opened merge request !315

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review

Hi @smustgrave,

If you can give the MR a try in the coming week (15th to 20th) before I merge it, it would be great!

smustgrave’s picture

smustgrave commented

Only question, and may be overkill but should it include a bootstrap library? So you don't have to rely on CDN?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Hi @smustgrave,

Sorry, as I have issue notifications disabled, I missed your comment.

You mean commit a version of the bootstrap library in the repository? No, we should not commit external assets.

Also users have the choice to use local or CDN in the theme settings, but for SASS compilation, the bootstrap library files should be retrieved locally.

  • grimreaper committed 97dce4f5 on 5.2.x 
    feat: #3548456 Add a package.json file in starterkits

By: smustgrave
By...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.