Problem/Motivation

The current method for allowing site admins to customize the headings used for warnings and errors is helpful, but it gets in the way of having that translated as we prep this module to support multiple languages.

  1. The heading settings should be removed and converted to hard coded strings that are properly run through the t().
  2. Other subheadings from the template should also be translated.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 alert_heading.png67.51 KBbaltowen

Issue fork alt_text_validation-3544944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swirt created an issue. See original summary.

baltowen made their first commit to this issue’s fork.

baltowen opened merge request !66

baltowen’s picture

baltowen commented
Status: Active » Needs review
StatusFileSize
new alert_heading.png67.51 KB

Hi, please review the MR. Would it make sense to remove the Customize alert headings fieldset from the module's configuration page since it is not possible to change the values anyway? For now, I have only disabled it. See below:

alert

Other subheadings from the template should also be translated.

I do not understand what the above refers to.

swirt’s picture

swirt
he/him
Primary language English
commented

Hi Baltowen, thank you for this and I am sorry for not getting back to you sooner. Yes it would be preferable to remove the fields completely since in the end, they should do nothing.

swirt’s picture

swirt
he/him
Primary language English
commented
Assigned: Unassigned » swirt

I have some time right now so I will make those changes.

swirt’s picture

swirt
he/him
Primary language English
commented

I think we also need a hook_update_n that removes the settings from the db.

swirt closed merge request !66

swirt reopened merge request !66

swirt’s picture

swirt
he/him
Primary language English
commented
Status: Needs review » Fixed

Thank you Baltowen for your work on this and your patience.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

swirt’s picture

swirt
he/him
Primary language English
commented

This has been released in #3583133: alt_text_validation 1.0.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.