Overview

CLI test (introduced #3525594: Publish CLI tool on npm) CI job is 100% failing since a few hours due to:

# npm audit report
astro  5.0.0-alpha.0 - 5.13.0
Severity: moderate
Astro allows unauthorized third-party images in _image endpoint - https://github.com/advisories/GHSA-xf8x-j4p2-f749
fix available via `npm audit fix`
node_modules/astro
1 moderate severity vulnerability
To address all issues, run:
  npm audit fix

https://git.drupalcode.org/project/experience_builder/-/jobs/6262159, for the nightly scheduled CI pipeline (https://git.drupalcode.org/project/experience_builder/-/pipelines/577174)

👆 this should not trigger a failing CI job, but at most a warning. (This particular vulnerability definitely doesn’t affect us — it’s Astro’s image optimization.)

Failure must mean "our code is broken", and an upstream vulnerability that might be relevant does not mean our code is broken.

Proposed resolution

Use https://docs.gitlab.com/ci/yaml/#allow_failureexit_codes

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

wim leers created an issue. See original summary.

wim leers’s picture

Assigned: Unassigned » wim leers
Issue summary: View changes

wim leers’s picture

Title: `CLI test` CI job failing 100% due to `npm audit report` » CI: `CLI test` job failing 100% due to `npm audit report` reporting a vulnerability
Status: Active » Needs review
Related issues: +#3422641: Add a "Validatable config" tests job to GitLab CI to help core evolve towards 100% validatability
wim leers’s picture

Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community

That worked: https://git.drupalcode.org/project/experience_builder/-/jobs/6263349 → yellow exclamation (warning) instead of red cross (hard failure) on the CI job 👍

Going ahead and merging to unbreak CI: https://git.drupalcode.org/project/experience_builder/-/commits/1.x/

wim leers’s picture

Issue summary: View changes
wim leers’s picture

Issue summary: View changes

  • wim leers committed 812f7239 on 1.x
    Issue #3542182 by wim leers: CI: `CLI test` job failing 100% due to `npm...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.