Problem/Motivation

#2950869: Entity queries querying the latest revision very slow with lots of revisions causes sorting problems on postgres and sqlite... fix it.

Steps to reproduce

Run EntityQueryTest

Proposed resolution

Add sort to query

Remaining tasks

User interface changes

None

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

Issue fork drupal-3541487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
alexpott’s picture

We already have sorts on other queries in these tests and we don't guarantee the result of an unsorted query so for me these changes are fine. Also both of these queries were added by #2950869: Entity queries querying the latest revision very slow with lots of revisions and would have failed on Postgres without the change to EntityQuery in that issue.

kim.pepper’s picture

Status: Needs review » Reviewed & tested by the community

Looks like a straight forward fix.

alexpott’s picture

Version: 11.x-dev » 10.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committing this so Postgres and SQLite are green again.

Committed and pushed 1b1133d1ff8 to 11.x and 71171df537a to 11.2.x and 23b79dfebd6 to 10.6.x and 1a0d6efea9d to 10.5.x. Thanks!

  • alexpott committed 1a0d6efe on 10.5.x
    Issue #3541487 by alexpott: Fix EntityQueryTest on SQLite and Postgres...

  • alexpott committed 23b79dfe on 10.6.x
    Issue #3541487 by alexpott: Fix EntityQueryTest on SQLite and Postgres...

  • alexpott committed 71171df5 on 11.2.x
    Issue #3541487 by alexpott: Fix EntityQueryTest on SQLite and Postgres...

  • alexpott committed 1b1133d1 on 11.x
    Issue #3541487 by alexpott: Fix EntityQueryTest on SQLite and Postgres
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.