Problem/Motivation

The module uses deprecated APIs and doesn't fully comply with Drupal coding standards, making it incompatible with Drupal 10 and harder to maintain. Updating the code will ensure Drupal 10 compatibility and improve overall code quality.

Steps to reproduce

1. Install and enable the module on a Drupal 10 site.
2. Run the **Upgrade Status** module or use the `drupal-check` command-line tool.
3. Review the list of deprecated APIs and compatibility issues.
4. Run `phpcs` with `Drupal` and `DrupalPractice` standards to identify coding standard violations.

Proposed resolution

  • Replace all deprecated APIs with their recommended Drupal 10 alternatives.
  • Refactor code to comply with Drupal and PSR-12 coding standards.
  • Update the `.info.yml` file to include:

    • core_version_requirement: ^8 || ^9 || ^10

  • Ensure all changes maintain existing functionality.
  • Provide a patch or merge request with the above updates.

Issue fork cart_item_count-3538716

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akashkumar07 created an issue. See original summary.

vinodhini.e made their first commit to this issue’s fork.

vinodhini.e opened merge request !1

akashkumar07’s picture

akashkumar07 commented
Status: Active » Needs work

Hi @Vinodhini
There are couple of small changes required related to coding standard in the MR.
Thanks!

vinodhini.e’s picture

vinodhini.e commented

Hi @akashkumar07,
I've updated the constructor parameter details and verified the code with PHPCS — no warnings or errors were reported.
Please review and let me know if anything else needs to be addressed.
Thanks..

akashkumar07’s picture

akashkumar07 commented
Status: Needs work » Needs review
akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Reviewed & tested by the community

Thanks @vinodhinie
I have verified the changes. LGTM!

akashkumar07’s picture

akashkumar07 commented
akashkumar07’s picture

akashkumar07 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.