Problem/Motivation

I noticed in the "FluidUI Settings" Form (located at /admin/config/fluidui/adminsettings) that if I check the checkboxes "Display preferences toolbox on admin pages" and "Enable the FluidUI widget as a Block" at the same time, and if I go to the node pages, the widget tries to render twice and we get an error:

Double render widget
Double render widget

If I go the admin pages, I don't see any issues at all

Steps to reproduce

Read instructions above

Proposed resolution

Add a condition for not rendering the admin widget when we load the node pages, and not load the block widget when visiting the admin pages.

Remaining tasks

N/A

User interface changes

Read information above.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
widget-double-render2.png104.36 KBdanrod
widget-double-render.png91.29 KBdanrod

Issue fork fluidui-3538593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

danrod created an issue. See original summary.

danrod’s picture

I created a MR for this, some external testing would be nice, but I did some tests myself and worked as expected.

Moving it to "Needs Review" hoping that someone could help me testing this.

danrod’s picture

Status: Active » Fixed
danrod’s picture

Status: Fixed » Needs review
danrod’s picture

Status: Needs review » Fixed
danrod’s picture

danrod’s picture

This needs to be applied to all branches

danrod’s picture

Version: 3.0.x-dev » 2.0.x-dev

danrod’s picture

For the 2.0.x branch, there's an error in the tests jobs, but I'll look into in in another issue. https://git.drupalcode.org/project/fluidui/-/merge_requests/43

  • danrod committed 11df7bea on 2.0.x
    Resolve #3538593 "Two checkboxes error"
    
danrod’s picture

Version: 2.0.x-dev » 8.x-1.x-dev

  • danrod committed 18b6647b on 8.x-1.x
    Resolve #3538593 "Two checkboxes error 8.x"
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.