Problem/Motivation

Update gitlab-ci.yml to test compatibility with Drupal 10 & 11

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

yaqbick created an issue. See original summary.

dieterholvoet’s picture

What exactly is being changed here? Didn't the OPT_IN_TEST_PREVIOUS_MAJOR variable indicate that tests were being run on both Drupal 10 and 11?

dxvargas’s picture

Assigned: yaqbick » Unassigned

@dieterholvoet, OPT_IN_TEST_PREVIOUS_MAJOR is not being removed, it's moved some lines under.

dxvargas’s picture

Version: 1.1.2 » 1.x-dev
Status: Active » Reviewed & tested by the community

The changes are correct, I mark the issue as RTBC.

claudiu.cristea’s picture

Status: Reviewed & tested by the community » Needs work

The PHP 8.4 test is failing

dxvargas’s picture

Status: Needs work » Needs review

I was dealing with the issues in pipeline regarding PhpUnit using max PHP version.

The tricky part is that there are a lot of deprecations affecting TMGMT and there is not much we can do about that.
Actually just a few of the deprecations are problematic, the ones that are considered risky.

I've tried many strategies, in the end I've chose to use a similar strategy that was adopted in webforms, to allow to fail:
https://git.drupalcode.org/project/webform/-/blob/6.3.0-beta4/.gitlab-ci...
But here I chose to run with the option "--do-not-fail-on-risky". It works and I consider it more targeted to what we need.

By the way, tmgmt_deepl has the same problems with TMGMT in PhpUnit tests with PHP 8.4. It seems that this is a generic problem for which there is no good solution.

I ask for review, maybe someone else has better ideas.

saidatom’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, moving to RTBC.

dieterholvoet’s picture

This module still supports Drupal 9.2. The PHPUnit attributes were only added in PHPUnit 10, which has only been supported since Drupal 11.2.0. Won't this cause issues?

dxvargas’s picture

@dieterholvoet with the changes here in .gitlab-ci.yml, we are testing with Drupal 10, for which the PHPUnit attributes don't work. Still, all the tests are passing. I would expect that also happens for Drupal 9.

Other remarks... Maybe it would be a good principle, to test with all supported Drupal versions.
For PHPUnit tests, even if they are not running successfully in Drupal 9, it doesn't mean that will cause issues, unless someone wants to run the module's tests in Drupal 9. But usually these tests are mainly used for module's own development.

dieterholvoet’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.