Problem/Motivation
Update gitlab-ci.yml to test compatibility with Drupal 10 & 11
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork tmgmt_ec_etranslation-3537771
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dieterholvoet commentedWhat exactly is being changed here? Didn't the
OPT_IN_TEST_PREVIOUS_MAJORvariable indicate that tests were being run on both Drupal 10 and 11?Comment #4
dxvargas commented@dieterholvoet,
OPT_IN_TEST_PREVIOUS_MAJORis not being removed, it's moved some lines under.Comment #5
dxvargas commentedThe changes are correct, I mark the issue as RTBC.
Comment #6
claudiu.cristeaThe PHP 8.4 test is failing
Comment #7
dxvargas commentedI was dealing with the issues in pipeline regarding PhpUnit using max PHP version.
The tricky part is that there are a lot of deprecations affecting TMGMT and there is not much we can do about that.
Actually just a few of the deprecations are problematic, the ones that are considered risky.
I've tried many strategies, in the end I've chose to use a similar strategy that was adopted in webforms, to allow to fail:
https://git.drupalcode.org/project/webform/-/blob/6.3.0-beta4/.gitlab-ci...
But here I chose to run with the option "--do-not-fail-on-risky". It works and I consider it more targeted to what we need.
By the way, tmgmt_deepl has the same problems with TMGMT in PhpUnit tests with PHP 8.4. It seems that this is a generic problem for which there is no good solution.
I ask for review, maybe someone else has better ideas.
Comment #8
saidatomLooks good, moving to RTBC.
Comment #9
dieterholvoet commentedThis module still supports Drupal 9.2. The PHPUnit attributes were only added in PHPUnit 10, which has only been supported since Drupal 11.2.0. Won't this cause issues?
Comment #10
dxvargas commented@dieterholvoet with the changes here in
.gitlab-ci.yml, we are testing with Drupal 10, for which the PHPUnit attributes don't work. Still, all the tests are passing. I would expect that also happens for Drupal 9.Other remarks... Maybe it would be a good principle, to test with all supported Drupal versions.
For PHPUnit tests, even if they are not running successfully in Drupal 9, it doesn't mean that will cause issues, unless someone wants to run the module's tests in Drupal 9. But usually these tests are mainly used for module's own development.
Comment #12
dieterholvoet commented