Problem/Motivation

In version 1.x the user could decide if the default local tasks should be shown or hidden. The default mode was to hide the default local tasks.

Steps to reproduce

- Install version 1.x and dont see the default local tasks.
- Install version 2.x and see the default local tasks.

Proposed resolution

- Add an option for hide / show default local tasks incl. update-hook.
- Hide corresponding block as visually hidden by JS.

Remaining tasks

Add documentation and tests.

User interface changes

- New option in admin form
- default local tasks hidden

Issue fork sticky_local_tasks-3536004

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jan kellermann created an issue. See original summary.

jan kellermann opened merge request !13

jan kellermann’s picture

jan kellermann commented
Status: Active » Needs review

Ready incl. phpunit tests.

Please review and feedback.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: Unassigned » gaurav.kapoor
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work

I noticed that the new feature to hide the local tasks works perfectly fine when using the default 'Olivero' theme, but it didn't have any impact when using a custom theme. So in case the theme removes the class 'block-local-tasks-block' the default local tasks tab isnt't removed. IMO a note for the admin regarding this, along with the settings or in the README, would be helpful.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: gaurav.kapoor » Unassigned
jan kellermann’s picture

jan kellermann commented
Status: Needs work » Needs review

Added text to admin form and README. Please have a look and give feedback or fix. Thank you in advance.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Reviewed & tested by the community

Looks good!! Moving to RTBC.

jan kellermann’s picture

jan kellermann commented
Status: Reviewed & tested by the community » Fixed

Thank you all for your work. This issue is merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.