Problem/Motivation
Module is not compatible with php 8.4 and throwing warning on drush cr.
Steps to reproduce
PHP Deprecated: Drupal\config_ignore\Form\IgnoreSettingsForm::buildForm(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/config_ignore/src/Form/IgnoreSettingsForm.php on line 36
Deprecated: Drupal\config_ignore\Form\IgnoreSettingsForm::buildForm(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /var/www/docroot/modules/contrib/config_ignore/src/Form/IgnoreSettingsForm.php on line 36
Proposed resolution
Fix php code and make it compatible
Remaining tasks
Merge code to main branch and make the release.
Issue fork config_ignore-3534880
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3534880-php-8.4-compatibility
changes, plain diff MR !46
Comments
Comment #3
lisotton commentedI applied the changes from the MR and it worked fine.
I'm marking the ticket as RTBC.
Comment #4
irafah commentedI can confirm that the MR worked for me on a PHP 8.4 site
Comment #5
bircherThanks for the contribution, I fixed this in the related MR from #3447321: PHPunit tests are failing on Drupal 11