Problem/Motivation

Events Subscriber are a mess:

 display_builder_entity_view.event_subscriber:
   class: '\Drupal\display_builder_entity_view\Event\DisplayBuilderEntityViewEventsSubscriber

display_builder_page_layout.page_variant_subscriber:
   class: Drupal\display_builder_page_layout\EventSubscriber\DisplayBuilderPageDisplayVariantSubscriber

display_builder_page_layout.page_layout_event_subscriber:
   class: Drupal\display_builder_page_layout\EventSubscriber\DisplayBuilderPageLayoutEventsSubscriber

 display_builder_views.page_layout_event_subscriber:
   class: Drupal\display_builder_views\EventSubscriber\DisplayBuilderViewsLayoutEventsSubscriber

Proposed resolution

Align them with a consistent naming.

For example:

For subscribing to Drupal\display_builder\Event\DisplayBuilderEvents:

 display_builder_entity_view.display_builder_subscriber:
   class: '\Drupal\display_builder_entity_view\EventSubscriber\DisplayBuilderSubscriber

display_builder_page_layout.display_builder_subscriber:
   class: Drupal\display_builder_page_layout\EventSubscriber\DisplayBuilderSubscriber

 display_builder_views.display_builder_subscriber:
   class: Drupal\display_builder_views\EventSubscriber\DisplayBuilderSubscriber

Other subscriptions:

display_builder_page_layout.page_variant_subscriber:
   class: Drupal\display_builder_page_layout\EventSubscriber\PageVariantSubscriber
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Assigned: pdureau » mogtofu33
Status: Active » Needs review
pdureau’s picture

I have tested by navigating the site and play with the 3 sub modules, everything seems to still work OK

  • pdureau committed 1c3e0e03 on 1.0.x
    Issue #3534566 by pdureau: Align event subscribers
    
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed
pdureau’s picture

Status: Fixed » Closed (fixed)