Extracted from #3534215: Implement WithDisplayBuilderInterface in Views which will act as a follow-up.

Problem/Motivation

In Views integration we have:

  • builder_config_id
  • display_builder_id
  • sources

Example:

id: articles
label: Articles
module: views
display:
  page_1:
      display_extenders:
        display_builder:
          builder_config_id: default
          display_builder_id: views_6861421654810
          sources: [ ... ]

In Entity display integration, we have:

  • entity_config_id
  • sources

Example:

id: node.article.default
targetEntityType: node
bundle: article
mode: default
content: {}
hidden: {}
third_party_settings:
  display_builder:
    enabled: true
    entity_config_id: default
    sources: [ ... ]

In page layout (not a config entity yet but will be: #3529737: Add proper page management), we have:

  • builder_config_id
  • builder_id
  • sources

Example:

id: page_layout
label: 'Page Layout'
builder_config_id: default
builder_id: page_layout_686785d880bc5
sources: []

Proposed resolution

Naming:

  • display_builder (instead of builder_config_id and entity_config_id).
  • instance (instead of builder_id and display_builder_id)
  • sources stays the same :)

Issue fork display_builder-3534335

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !27

pdureau’s picture

pdureau commented
Status: Active » Needs work

I have introduced Drupal\display_builder\StorageProperties

Need works because some docblocks are missing.

DisplayBuilderDisplayVariant was not updated because out of this issue scope, but i can amend my commit with this addition if necessary.

pdureau’s picture

pdureau commented
Assigned: pdureau » just_like_good_vibes
Status: Needs work » Needs review

I do DisplayBuilderDisplayVariant too?

pdureau’s picture

pdureau commented
Assigned: just_like_good_vibes » mogtofu33
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau
Status: Needs review » Needs work
pdureau’s picture

pdureau commented

I also align properties from DisplayVariant plugins

id: test-display_builder-0
label: 'pdu content'
variant: display_builder
variant_settings:
  id: display_builder
  label: null
  weight: 0
  uuid: 5c2772dc-fa4e-4cbb-9fd4-8f9192191376
  display_builder_id: page_manager_686c23fdb11dd
  display_builder_sources: [...]

id: test-display_builder_page-0
label: 'Display Builder (Full page)'
weight: 0
variant: display_builder_page
variant_settings:
  id: display_builder_page
  label: null
  uuid: 7f2ebdf1-9e1c-4ffd-b300-b4662147d6e1
  display_builder_id: page_manager_686c232cd3787
  display_builder_sources: : [ ...]
  • from display_builder_sources to sources
  • from display_builder_id to instance
  • from builder_config_id (not stored in config yet) to display_builder
pdureau’s picture

pdureau commented

Done. Let's test again after #3534566: Align event subscribers because they alter the same files

pdureau’s picture

pdureau commented
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

  • pdureau committed 5c8dd597 on 1.0.x 
    Issue #3534335 by pdureau: Align config storage properties
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed
pdureau’s picture

pdureau commented
Status: Fixed » Closed (fixed)

Remove Isla