I was looking at changing the contribution record template, which is custom in the contribution_records module, I was not expecting another custom override in bluecheese. We should avoid custom code overriding custom code.

Content-type-specific CSS is good in bluecheese. This MR moves the attachment to bluecheese_preprocess_node() so there is not a blocker to removing node--contribution-record--full.html.twig and getting the customizations into the contribution_records version of the template.

Issue fork bluecheese-3533772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drumm created an issue. See original summary.

drumm opened merge request !174

fjgarlin’s picture

fjgarlin commented

Good call. I've actually been meaning to remove the duplicated twig templates from "contribution_records". However, we will need to add "bluecheese" as dependency so we can make reference to the SDC.

  • fjgarlin committed ffcf01fa on 2.x authored by drumm 
    Issue #3533772 by drumm: Include content-type-specific library...
fjgarlin’s picture

fjgarlin commented
Status: Active » Fixed

Merged. I will follow up clean up duplicated templates and updating dependencies.

  • fjgarlin committed dd3badff on 2.x 
    #3533772 move template from bluecheese to the contrib module.
fjgarlin’s picture

fjgarlin commented

The above comment shows the removal of the template from bluecheese, and the below commits the update of the template in the contrib module to use bluecheese:
- https://git.drupalcode.org/project/contribution_records/-/commit/1d18971...
- https://git.drupalcode.org/project/contribution_records/-/commit/f85db9c...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.