Problem/Motivation

We now run phpunit tests as part of the lint stage, to allow always running on all supported PHP versions.

This makes it noticeable that these two tests take about 25 seconds each:

Drupal\Tests\Core\Command\QuickStartTest
Drupal\Tests\Core\Recipe\RecipeQuickStartTest

Given we run them on three different versions, that's 25s * 2 * 3 or about 6 minutes wall time of unit tests.

If we move them to build tests, they'll be fast build tests instead of slow unit tests.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3533030

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Status: Active » Needs review
mondrake’s picture

Status: Needs review » Needs work

Test failures seem legit.

mondrake’s picture

IMHO we should convert the tests metadata from annotations to attributes here, given that #3526490: Convert test annotations to attributes in Drupal/BuildTests is RTBC.

mondrake’s picture

Title: Consider moving quickstart tests to build tests » Move QuickStart tests to build tests
Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Weird, but something about attributes just looks so clean. Seems like a good conversion.

  • alexpott committed ef781e50 on 11.2.x
    Issue #3533030 by catch, mondrake: Move QuickStart tests to build tests...
alexpott’s picture

Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 11.2.x since this is a test-only change.

Committed and pushed 7ed859f2b2b to 11.x and ef781e5024e to 11.2.x. Thanks!

  • alexpott committed 7ed859f2 on 11.x
    Issue #3533030 by catch, mondrake: Move QuickStart tests to build tests
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sweetchuck’s picture