Problem/Motivation

The constructor does $this->fileUploadHandler = \Drupal::service('file.upload.handler'); but file.upload.handler does not exist... file.upload_handler is the correct name

Proposed resolution

Use correct service name.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

None

Issue fork drupal-3531978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !12456

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

This should go into 10.6.x and 10.5.x.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward and does appear to be a typo.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Good catch. If we used \Drupal\file\Upload\FileUploadHandler::class as the service name this would probably have been caught sooner.

larowlan closed merge request !12456

  • larowlan committed 9229f89b on 10.6.x 
    Issue #3531978 by alexpott: \Drupal\jsonapi\Controller\FileUpload...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 10.6.x and backported to 10.5.x - thanks!

  • larowlan committed 6c3d519e on 10.5.x 
    Issue #3531978 by alexpott: \Drupal\jsonapi\Controller\FileUpload...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 10.6.x-dev » 10.5.x-dev

 

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.