Problem/Motivation

#3529067: Make Island plugins configurable will make this configurable, but we need a sensible default now.

ComponentLibraryPanel::getDefinitionsForProvider() is excluding component from any theme other than the default one. That's not good because Project often use a nearly empty custom theme overriding a shared theme implementing a design ssytem

Proposed resolution

Simpler solution, just remove this:

      if ($definition['extension_type']->value === 'theme' && $definition['provider'] !== $provider) {
        continue;
      }

Better solution: get ancestor themes of the default active theme.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Assigned: pdureau » mogtofu33
Status: Active » Needs review
pdureau’s picture

Assigned: mogtofu33 » pdureau
Status: Needs review » Needs work

Oops, something else to check before review

pdureau’s picture

Assigned: pdureau » just_like_good_vibes
Status: Needs work » Needs review

@mogtofu33 it is ok :) you can review

pdureau’s picture

mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

  • mogtofu33 committed 056c1911 on 1.0.x authored by pdureau
    Issue #3530369 by pdureau: Make components from ancestor themes...
mogtofu33’s picture

Status: Fixed » Closed (fixed)
pdureau’s picture

Title: [1.0.0-alpha1] Make components from ancestor themes available » Make components from ancestor themes available
Issue tags: +display_builder-1.0.0-alpha1