Closed (fixed)
Project:
Display Builder
Version:
1.0.x-dev
Component:
Main / Misc.
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jun 2025 at 11:54 UTC
Updated:
11 Jul 2025 at 17:38 UTC
Jump to comment: Most recent
Comments
Comment #2
just_like_good_vibesComment #3
pdureau commentedComment #4
mogtofu33 commentedCurrently focus is on 11, no specific work or test is made for 10.3.
We will try to follow UI Patterns 2.x compatibility in a second time if I have bandwidth.
Comment #5
grimreaperComment #6
grimreaperRegarding #3529127: Play nice with layout builder, Layout Builder is using features introduced in the conversion of hooks into OOP code like https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/layou...
So I am not sure it will be feasible with Core 10.x
Comment #7
mogtofu33 commentedComment #8
pdureau commentedLet's do it:
core_version_requirement: ^10.3.4 || ^11Comment #9
grimreaperFor hooks as PHP class.
Which approach do we take?
I am for the one file per hook.
Comment #12
pdureau commentedVote:
As far as we know, the same mechanisms are available in all strategies.
By the way, we can do dependency injection.
Let's do a single file by module by default. If we consider later than it will be better to split (one file per hook, one file per related hooks/logic) , let's do it.
Let's migrate only
display_builder_views_preprocess_views_view(because others ones are temporary or impossible).Let's not forget to remove all references to Drupal 10. For example, in all info.yml:
core_version_requirement: ^10.3.4 || ^11Comment #13
grimreaperComment #14
grimreaperdisplay_builder_entity_view_module_implements_alter preserved as it will be deleted in #3529127: Play nice with layout builder
Comment #16
pdureau commentedComment #18
mogtofu33 commentedComment #19
pdureau commented