Problem/Motivation

2 reasons to work on this compatibility:

  • Display Builder will be released in fall 2025, during the Drupal 11.2 lifecycle. Drupal 10 will reach end of life mid-late 2026, when Drupal 12 is released. So, there is a full year of overlap.
  • UI Patterns currently works with Drupal: ^10.3.4 || ^11

However:

Proposed resolution

Let's talk, and let's use this issue for any MR with improvements of Drupal 10 compatibility.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

Title: [1.0.0-alpha1] Drupal 10 compatibility » Drupal 10 compatibility ?
Assigned: just_like_good_vibes » Unassigned
pdureau’s picture

Issue summary: View changes
mogtofu33’s picture

Status: Active » Needs work

Currently focus is on 11, no specific work or test is made for 10.3.
We will try to follow UI Patterns 2.x compatibility in a second time if I have bandwidth.

grimreaper’s picture

Title: Drupal 10 compatibility ? » Drupal 10 compatibility?
Category: Bug report » Feature request
Status: Needs work » Active
grimreaper’s picture

Regarding #3529127: Play nice with layout builder, Layout Builder is using features introduced in the conversion of hooks into OOP code like https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/layou...

#[Hook('entity_view_alter', order: Order::Last)]

So I am not sure it will be feasible with Core 10.x

mogtofu33’s picture

Status: Active » Needs work
pdureau’s picture

Title: Drupal 10 compatibility? » Convert hooks to PHP class and drop Drupal 10.3
Category: Feature request » Task
Status: Needs work » Active
Issue tags: +display_builder-1.0.0-alpha3

Let's do it:

grimreaper’s picture

For hooks as PHP class.

Which approach do we take?

  1. One class file for all hooks per module
  2. One file per hook
  3. One file per related hooks/logic if possible

I am for the one file per hook.

pdureau credited goz.

pdureau’s picture

Vote:

  • one file per hook >> Florent
  • a single file by module >> Mikael, Jean
  • one file per related hooks/logic if possible >> Christian

As far as we know, the same mechanisms are available in all strategies.

By the way, we can do dependency injection.

Let's do a single file by module by default. If we consider later than it will be better to split (one file per hook, one file per related hooks/logic) , let's do it.

Let's migrate only display_builder_views_preprocess_views_view (because others ones are temporary or impossible).

Let's not forget to remove all references to Drupal 10. For example, in all info.yml: core_version_requirement: ^10.3.4 || ^11

grimreaper’s picture

Assigned: Unassigned » grimreaper
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Needs review

display_builder_entity_view_module_implements_alter preserved as it will be deleted in #3529127: Play nice with layout builder

pdureau’s picture

Assigned: Unassigned » mogtofu33

mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed
Issue tags: -display_builder-1.0.0-alpha3 +display_builder-1.0.0-alpha2
pdureau’s picture

Status: Fixed » Closed (fixed)