Problem/Motivation

I experienced an unexpected behaviour when there are two modals in the same page.
In a certain page and at a certain time, two modals are piled up, the first being bigger than the second one, I can only see the first one.

  • If I close the first one with Esc key or clicking outside the modal, I can see the second one and I can interact with it as expected.
  • If I close the first one with the Right button, the second one is closed as well without doing anything else.
    And the Redirect Link defined for the second modal is followed!

I would prefer to be able to act on second one as well 😇

Issue fork modal_page-3528843

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gbmapo created an issue. See original summary.

renatog’s picture

Nice catch

zeshan.ziya made their first commit to this issue’s fork.

zeshan.ziya’s picture

Assigned: Unassigned » zeshan.ziya
Issue tags: +Drupal Mumbai Meetup

I am picking it up.

zeshan.ziya’s picture

Status: Active » Needs review

@gbmapo I have raised an MR to fix the issue. Please review. CC: @renatog

renatog’s picture

Version: 5.1.0 » 5.1.x-dev
Assigned: zeshan.ziya » Unassigned
Issue tags: +Needs manual testing, +Novice

Thank you so much @zeshanziya - Great contribution. Really appreciated

I didn’t test yet however Just Reviewed the MR and seems good

I’m OOO traveling, but if someone test that please let us know and we’ll be able to merge

shubham_pareek_19’s picture

reviewing it.

renatog’s picture

Amazing! Thanks @shubham_pareek_19

If works well for your please let us know and we can move forward

renatog’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing, -Novice

Tested and everything worked like a charm

  • renatog committed a02be4b3 on 5.1.x authored by zeshan.ziya
    Issue #3528843 by zeshan.ziya, renatog, gbmapo, shubham_pareek_19: Right...

  • 81f17c22 committed on 6.0.x
    Issue #3528843 by zeshan.ziya, renatog, gbmapo, shubham_pareek_19: Right...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Moved to the dev branches 5.1.x and 6.0.x

Thanks @gbmapo for reporting and @zeshanziya for your great fix

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.