(closed as duplicate of the parent issue, #3227637: NodeController::revisionOverview is uncacheable, which has been reverted and reopen since)
Problem/Motivation
The test NodeRevisionsAllTest::testRevisions() fails in 11.1.x.
It is failing in 11.1.7, but passes in 11.1.6.
git bisect reveals this culprit: #3227637: NodeController::revisionOverview is uncacheable
Interestingly, 11.x also contains this commit, but here we don't get the failure.
Steps to reproduce
Proposed resolution
Investigate further:
- Is the revision list cached at all in 11.x?
- What would be required cache tags for a revision list? Can this even be cached ever?
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3525111
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
donquixote commentedThe MR works for me in local.
However, I am a bit puzzled by this:
Maybe this is not cached at all in 11.x?
If you change (or delete) a revision that does not change the current/published revision, does this even invalidate cache tags for the entity/node?
Comment #4
acbramley commentedI think we can close this one now that the original is reverted and test both branches over there?
Comment #5
donquixote commentedOk for me.
In the original issue we need to determine if a revision list should be cacheable at all, with which cache tags, and then add more tests.
Comment #6
donquixote commented