Problem/Motivation

Installing more recipes on the same instance, sometimes gets to a brick wall. Getting: The configuration 'block.block.gin_messages' exists already and does not match the recipe's configuration error.
I installed a recipe that has dependencies to drupal_cms_starter, drupal_cms_news, then I installed another one with dependency to drupal_cms_blog. I am getting the error mentioned above.
The only way I could get the error to go away was by adding

config:
  strict: false

in the drupal_cms_admin_ui.

Steps to reproduce

Proposed resolution

Add config: strict: false in drupal_cms_admin_ui.
I don't think the configs added by this recipes are not supposed to be overwritten.

Issue fork drupal_cms-3523920

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ciprian.stavovei created an issue. See original summary.

ciprian.stavovei’s picture

Status: Active » Needs review
phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

I agree; there's no particular reason for this recipe to compare config strictly. RTBC if tests pass.

phenaproxima’s picture

Title: Subsequent recipes installation breaks because of gin config from drupal_cms_admin_ui » drupal_cms_admin_ui cannot be applied more than once because
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

On second thought...although I approve of the fix, I am kind of wondering how this is happening. The drupal_cms_admin_ui recipe, like all our recipes, has a test which proves it can be applied twice. So something else must be modifying the block and making it deviate from our shipped config.

Again - I think that setting strict: false is completely fine, and the MR is RTBC. But I want to more thoroughly understand the problem before I merge this, just in case it points to a larger bug that needs a more comprehensive fix.

Can you provide steps to reproduce, starting from a bare Drupal CMS site -- or whatever it is you started with?

arthur_lorenz’s picture

Status: Postponed (maintainer needs more info) » Needs review

Thanks, we are currently working on creating recipes based on Drupal CMS for our Lupus Decoupled stack. To provide a streamlined editing experience we base all our recipes on the drupal_cms_starter recipe. That's how we noticed that issue.

To reproduce it using only drupal_cms recipes:

* Fresh Drupal install
* Apply drupal_cms_starter recipe
* Apply drupal_cms_news recipe
* Apply drupal_cms_starter recipe again

It fails because the gin_messages-block's weight got altered.

phenaproxima’s picture

we base all our recipes on the drupal_cms_starter recipe

So this is the one recipe in our stack which is not meant to be applied more than once. I would suggest not using this recipe, and instead compose your recipe using the smaller parts of Drupal CMS (such as drupal_cms_admin_ui, or any of the other recipes we have, except for drupal_cms_starter).

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

But, having said that, I think I'm still okay merging this patch. There's no harm in making drupal_cms_admin_ui non-strict.

phenaproxima’s picture

Title: drupal_cms_admin_ui cannot be applied more than once because » drupal_cms_admin_ui should not use strict config comparison, so it can be more readily used in other recipe stacks

phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Merged into 1.x and cherry-picked to 1.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.