Problem/Motivation

There is an error on the class added on the ul element of badge_group component.

The class added is fr-badge-group instead of fr-badges-group

Steps to reproduce

On a card component, the badge is displayed below the image instead of on top of it

card before patch
code before patch

Proposed resolution

Replace class name by "fr-badges-group" in badge component
Card aftre patch
Code after patch

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 code-after-patch.png19.63 KBmaboy
#3 card-after-patch.png110.56 KBmaboy
#3 code-before-patch.png19.6 KBmaboy
#3 card-before-patch.png111.7 KBmaboy

Issue fork ui_suite_dsfr-3519711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

maboy created an issue. See original summary.

maboy opened merge request !161

maboy’s picture

maboy commented
Issue summary: View changes
StatusFileSize
new card-before-patch.png111.7 KB
new code-before-patch.png19.6 KB
new card-after-patch.png110.56 KB
new code-after-patch.png19.63 KB
maboy’s picture

maboy commented
Assigned: maboy » Unassigned
Status: Active » Needs review

  • maboy committed aacdf865 on 1.1.x 
    Issue #3519711 by maboy: Class name error for badge-group component
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Needs review » Fixed

nice catch, thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.