Problem/Motivation

Project needs to be updated to support Drupal 11.

Proposed resolution

Merge the following first:

Update code from D10 update ready for D11 release.

10.3 is minimum version required due to changing views plugin annotation to attribute.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ✅ Performance
  • ✅ Security
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ✅ Release notes snippet
  • ➖ Release

Release code snippet

#3519377: Drupal 11 compatibility fixes

Issue fork views_advanced_cache-3519377

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elc created an issue. See original summary.

elc opened merge request !3

elc’s picture

elc commented
Assigned: elc » Unassigned
Issue summary: View changes
Status: Active » Needs review

MR made.

Many phpstan and phpcs issues still present in the module.

elc’s picture

elc commented
Issue summary: View changes

@todo Move the following into their own issues and do not merge them as part of this issue:

  • GitlabCI setup
  • phpstan/cs fixes
elc’s picture

elc commented
Issue summary: View changes

Updated MR to branch off 8.x-1.x once these are merged:

  • elc committed 2dc36f90 on 8.x-1.x 
    [#3519377] Drupal 11 compatibility fixes.

  • elc committed 0b65e490 on 8.x-1.x 
    Revert "[#3519377] Drupal 11 compatibility fixes."

elc opened merge request !9

  • elc committed bce4904e on 2.x 
    [#3519377] Drupal 11 compatibility fixes.
elc’s picture

elc commented
Version: 8.x-1.x-dev » 2.x-dev
Assigned: Unassigned » elc
Status: Needs review » Needs work

Failure on Drupal 11 testing caused by removal of "spaceless" in twig, resulting in extra whitespace characters being expected in the output.
#3486170: Remove use of deprecated "spaceless" filter in core templates

Wrap expected text in version_compare to handle testing in both branches. May need to be fixed if Twig is updated for Drupal 10.5.x branch.

elc changed the visibility of the branch 2.x to hidden.

elc opened merge request !10

  • elc committed c832a014 on 2.x 
    [#3519377] Fix tests in D11.1 due to removal of spaceless from core.
elc’s picture

elc commented
Assigned: elc » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.