Problem/Motivation
In PHP 8.4, declaring functions/methods with parameters containing null as a default value, but without null as one of the types (either as a nullable syntax or as a Union type with null) is deprecated.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullabl...
Steps to reproduce
phpcs --standard=SlevomatCodingStandard --sniffs=SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue
FILE: /app/docroot/modules/contrib/devel_entity_updates/src/DevelEntityDefinitionUpdateManager.php
-----------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
191 | ERROR | [x] Parameter $storage_definition has null default value, but is not marked as nullable.
191 | ERROR | [x] Parameter $original_storage_definition has null default value, but is not marked as nullable.
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3519207-devel-entity-update-3.patch | 1.09 KB | kiseleva.t |
Issue fork devel_entity_updates-3519207
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
kiseleva.t commentedExported MR into patch to use in composer.
Comment #4
liam morlandThe merge request should have its target switched to 5.0.x. If desired, once merged, this can be cherry-picked onto 4.2.x.
Comment #5
plachApproved/merged, thanks!