Margin settings are getting passed as strings instead of integers, which results in the margin values being ignored and/or the grid being broken.

Issue fork macyjs-3518151

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aron01 created an issue. See original summary.

aron01 changed the visibility of the branch 3518151-margin-settings-are to hidden.

aron01 opened merge request !2

aron01’s picture

aron01 commented

I tested with these settings:
1440: 4,
1200: 4,
1024: {margin:{x:20,y:10,},columns:10},
640: 3,
360: 2,

kaszarobert made their first commit to this issue’s fork.

  • kaszarobert committed 9c8ae26e on 1.1.x authored by aron01 
    Issue #3518151 by aron01: Margin settings are getting passed as strings...
kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Assigned: aron01 » Unassigned
Status: Active » Fixed

MR looks fine and fixes the mentioned problem. Thanks for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.