Remove broken link in MenuTreeStorageInterface

Working on it.

Hi @mortona2k,
This doc was foundational reading for understanding how Drupal (especially 6 & 7) stored menu items, taxonomy terms, etc., before full-fledged entity trees and interfaces were in place.
Conceptually it is relevant but not for inline documentation that most devs read.

Think some replacement may be needed vs just removing, but IS is incomplete.

Having a dead link is no use to anyone. I am fine with this removing that link only and having a followup to add documentation about menu ordering. One should search for an existing issue.

Fair enough, but for good practice think the issue summary should still be complete

Opened https://www.drupal.org/project/drupal/issues/3518551

I think the minimal scope here of removing the broken link is still a good novice task. We can simply remove the part of the sentence after the comma. The followup issue can handle adding additional content as needed from the historical reference.

The Drupal Contribution Mentoring team is triaging issues for DrupalCon Vienna 2025, and we are reserving this issue for Mentored Contribution during the event. After October 17, this issue returns to being open to all. Thanks!

Applied IS template, minimal removal and re-write of IS, updated the Remaining tasks.

After questions in Slack, I am changing the title to be explicit.

I’ve reverted the text copy to the previous version and removed the dead link. I’ve implemented the change requested in #11.

@suryanto, thanks for the change.

The next step here, which is still Novice level, is to review and decide if this can be set to RTBC. The full steps for that are at https://www.drupal.org/community/contributor-guide/task/review-a-merge-r....

Those steps are detailed and some may not apply to this issue. A key part is to comment on exactly what you did to review the issue. I know this is a 'simple' fix but it is a good habit to develop. As in, you read all the comments, or used some git command (--color-words would be useful here) or something else. And it is OK to not do everything part of a review. For example, I often review comments but not code and I say that clearly in my comments.

I have read all the comments, walk through the changes, the MR is correct. Moving this into RTBC.

Note : Didn't do any code test as the changes are in the commented section of the code.
I've also updated the IS accordingly.

@akmalfikri, Thanks for the detailed comment.

I review the MR and I agree that the change is correct and agrees with the issue summary and #11. I applied the diff to HEAD and got a screen full of 'error: patch failed' errors. Then I went back to the MR and saw that there are 1117 commits. Clearly, that is far too many for this small change. So, this now needs a rebase. Another check is that the diff file is 29MB!

There are instructions for rebasing a merge request in the Drupal Develop docs.

Oops, the status should be 'needs work'.

I have finished rebase the merge request. There were no conflict during rebase.

@suryanto, were there any conflicts or other problems with the rebase?

@quietone, there are no conflicts during rebase. Can we restore this issue as RTBC?

@suryanto, yes. Especially true for this same change.

When there are no conflicts during a rebase one should state that in a comment, adding that is why it is being restored to RTBC. When there are conflicts it is best to state what they were so those files can be reviewed. However, we also know that some conflicts are simple and some are complex. So, the focus becomes commenting on what happened during the rebase so all contributors know what happened. It is OK to say things like 'there were conflicts in file X' and that should be reviewed. When reviewers know what to focus on, it saves us all time.

As per #25 there is no conflicts, and I have confirmed this. Moved back to RTBC.

Thanks, @quietone, for the clarification and guidance.

I’ll make sure to include details about the rebase outcome in future. Whether there were no conflicts or which files had conflicts, so reviewers know what to look at.

Appreciate the feedback!

Thanks everyone, this is ready to commit. Congratulations!

And remember that issues tagged 'Novice' are for Drupal first time contributors. As you gain experience with the contribution process you should move to other issues.

I am assigning this to myself to commit. Actually, I am trying to do that now but I am having trouble with composer in DDEV.

I didn't realize I had xdebug enabled on my environment for only core committing.

Committed to 11.x and cherry-pick 11.3.x and 11.2.x.

Thanks!

Adding to parent issue for fixing broken URLs