Problem/Motivation

I need to evaluate this module in Drupal 10 / Drupal 11

Steps to reproduce

Install Drupal 10 or Drupal 11, unable to bring this module in without doing some composer wizardry or some other hacks

Proposed resolution

Merge the merge request that I have created

Remaining tasks

Review/merge

User interface changes

N/A

API changes

Minor, added a configure in the .info.yml so that the gear icon and hyperlink to the simple_favs settings page is available in the modules listing page.

Data model changes

no data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad changed the visibility of the branch 1.0.x to hidden.

  • joseph.olstad committed d8eee82a on 1.0.x
    Issue #3517157 by joseph.olstad: Drupal 10 and Drupal 11 compatibility
    
rvilar’s picture

Status: Active » Fixed

Changes merged. Thanks for the MR

joseph.olstad’s picture

Version: » 1.0.x-dev

Thanks!

joseph.olstad’s picture

Hello Ramon, could you please also tag an alpha release and publish it so that it shows up as supported on the project page for simple_favs? I could do this for you if you grant me enough permissions.

rvilar’s picture

Hi Joseph

Thanks for your help. Adding you the permissions so feel free to create a new release.

joseph.olstad’s picture

joseph.olstad’s picture

joseph.olstad’s picture

joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned
StatusFileSize
new423 bytes
new933 bytes
new4.86 KB
new4.78 KB

@rvilar , I've done a major spike on this, started publishing a 2.0.0 release, up to 2.0.0-rc1, it's getting quite advanced and functional with quite a bit more configuration options. A db storage option (fallback to cookie for anonymous users.).

I would really like to be able to have a bit more permissions for this project seeing as I just put two solid days into it.

I'll put some screenshots up:

My Favourites block (english) example

screenshot of the favourites block in french

Now for the heart block:
Unselected:
unselected heart

Now for a selected heart
selected heart

joseph.olstad’s picture

Improved it even more, now has a views data field plugin

https://www.drupal.org/project/simple_favs/releases/2.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.