Problem/Motivation

Make the module D11-compatible

Proposed resolution

Update compatibility to include ^11

Replace deprecated function user_roles() in shortcutperrole.module:31 with Drupal\user\Entity\Role::loadMultiple()

Replace deprecated function user_roles() in src/Form/ShortcutPerRoleSettingsForm.php:60 with Drupal\user\Entity\Role::loadMultiple()

CommentFileSizeAuthor
#4 shortcutperrole_d11_compatible.PNG7.33 KBggh

Issue fork shortcutperrole-3514094

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chris dart created an issue. See original summary.

chris dart opened merge request !3

chris dart’s picture

chris dart commented
Status: Active » Needs review
ggh’s picture

ggh commented
StatusFileSize
new shortcutperrole_d11_compatible.PNG7.33 KB

As per Upgrade status - this is compatible

jwilson3 made their first commit to this issue’s fork.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Reviewed & tested by the community

The code changes look good. I fixed some phpcs issues introduced in the patch and tested in the UI.

Before:

Only local images are allowed.

After:

Only local images are allowed.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Version: 2.0.1 » 2.1.x-dev

I'm creating a new 2.1.x branch to merge this, so that the 2.0 branch retains integration with older versions of Drupal.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Reviewed & tested by the community » Fixed

This fix is included in release 2.1.0

Thanks @chris dart.

lostkangaroo’s picture

lostkangaroo commented

It looks like the current 2.1.0 release does not include the D11 compatibility MR commit as advertised. Would you be so kind as to do another patch release of 2.1.1 based on the current 2.1.x branch.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Thanks for flagging that @lostkangaroo. My apologies.

2.1.0 was meant to add Drupal 11 support, but it was tagged off the wrong commit. It’s identical to 2.0.1 and should be ignored.

To fix this, I've tagged 2.1.1 and updated the release notes on 2.1.0 to indicate the same.

You can verify this by reviewing the tags shown on the repository graph in gitlab here:

https://git.drupalcode.org/project/shortcutperrole/-/network/2.1.x?ref_t...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.