Problem/Motivation

Follow-up to:

#3511877: Add SDDS global header styling

In that issue, a header_panel was introduced that has a soft border and two split slots.

We have generic components (e.g. container, columns, flexible slot) that were improved in this issue:

#3510427: Add SDDS global footer styling

It would be nice to move the styling needed for the header menu area into these generic components somehow.

Steps to reproduce

Proposed resolution

TBD how they would be integrated into the existing components.

Remaining tasks

  • Figure out best way to integrate
  • Update code including removing header_panel
  • Review/test/commit

User interface changes

The header_panel won't show up but the equivalent features would be available on the generic components.

API changes

Data model changes

CommentFileSizeAuthor
#10 sdds-social-media-footer-testing.png435.42 KBkristen pol
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kristen pol created an issue. See original summary.

kristen pol’s picture

kristen pol’s picture

Note the split component functionality that we'd like in the footer styling should be considered when doing this one too.

#3510427: Add SDDS global footer styling

heyyo made their first commit to this issue’s fork.

kristen pol’s picture

Assigned: Unassigned » kristen pol
Status: Active » Needs review

Cool! I'll take a look :)

Note that Lionel and I talked about this one yesterday and the plan is to keep the header_panel but add the styles from it to the generic components to show both ways of building the header.

kristen pol’s picture

Ah... the social media stuff got into this MR... hmm... I'll still just try to test just the columns+container.

kristen pol’s picture

Title: Update SDDS components to move header_panel features to generic components » Improve SDDS generic components and add social media components
Priority: Normal » Major

Had a call with Lionel and all the social media changes are going to happen in this MR. He's doing a bit of cleanup right now.

kristen pol’s picture

Thanks! I'll review.

kristen pol’s picture

StatusFileSize
new435.42 KB

I've done some minor name tweaks and tested and this is working pretty well... I had some layout issues but maybe my settings aren't quite right.

This is good enough to merge and we can make a release for Pam.

Then we can do any minor tweaks in another issue.

testing sdds footer and social media components with colored backgrounds

kristen pol’s picture

Assigned: kristen pol » Unassigned
Status: Needs review » Fixed

Thanks!

kristen pol’s picture

Status: Fixed » Closed (fixed)

Recording of testing:

https://youtu.be/5l7gxrf764k

kristen pol’s picture