Problem/Motivation

2.1.0 introduces a change in the AddToCartLink constructor that may affect to sites that manually instantiates this class.

This API change is not announced in the release notes and could potentially break sites.

Steps to reproduce

* Install module in version 2.0.6
* Manually instantiate for any reason AddToCartLink or AddToWishListLink class
* Upgrade to 2.1.0
* Site breaks because the 2 constructor parameter is required

Proposed resolution

Add BC dance to deprecate the old constructor and give time to site admins to adapt their sites.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork commerce_add_to_cart_link-3512138

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !7

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

MR created.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

Thank you for your contribution. Looks good.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Merged. Thank you for your contributions. 🍰
Waiting for the release as I don't have release privileges.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

agoradesign’s picture

agoradesign commented
Status: Fixed » Needs work

the MR wasn't merged, seems it isn't mergeable anymore

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Thank you for merging!

I think we can mark it as fixed now.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Fixed

Shweet! Thanks all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.